-
Notifications
You must be signed in to change notification settings - Fork 120
refactor: Replace preprocessor condition _WINDOWS with _WIN32 #1911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace preprocessor condition _WINDOWS with _WIN32 #1911
Conversation
|
Why was this suddenly required? |
|
If anything |
|
Yes maybe make a pass and just use _WIN32 everywhere? Do you still have this compile error? |
looking at documentation i agree we should just use _WIN32 instead of _WINDOWS just make simple and standard |
|
Updated it to use _WIN32 instead of _WINDOWS |
xezon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 48 files using _WINDOWS in this project, but only 11 files edited here.
e13bdae to
4acbc0b
Compare
Found and updated all 48 files |

Win32 Debug build was failing for me until I added this fix